Prawnto 2.0 and Prawn 0.4 compatibility
Reported by shmel | January 19th, 2009 @ 05:21 PM
Since Prawn 0.4 has been split into two components there is a need to add "require 'prawn/layout'" to be able to work with tables. Prawnto's prawnto.rb seems to be the best place to do it, however it will break backward compatibility with earlier versions of Prawn.
Comments and changes to this ticket
-
shmel January 24th, 2009 @ 03:52 PM
- Assigned user set to “Gregory Brown”
-
Gregory Brown January 24th, 2009 @ 03:55 PM
- Assigned user cleared.
-
Gregory Brown January 24th, 2009 @ 03:58 PM
Please do not assign any tickets to me. I don't maintain Prawnto. But I'm working on getting thorny_sun set up with proper access rights to this tracker.
-greg
-
Gregory Brown January 24th, 2009 @ 04:00 PM
This should be backwards compatible, and also offer optional support for this extension moving forward, without requiring the gem to be installed for those who do not use tables.
begin require "prawn/layout" rescue LoadError end -
thorny_sun (at cracklabs) January 25th, 2009 @ 06:13 PM
- Assigned user set to “thorny_sun (at cracklabs)”
-
thorny_sun (at cracklabs) January 25th, 2009 @ 06:22 PM
- State changed from “new” to “open”
Should i really include prawn/layout by default? I mean shouldn't I leave that up to the user? Otherwise what's the point of splitting up the library?
-
Gregory Brown January 25th, 2009 @ 07:47 PM
Totally up to you. I'm just suggesting that you certainly should not make in mandatory. The code I suggested loads it if it is installed, and ignores it otherwise. (So there is still a point to the split-up)
But I have no opinion on whether Prawnto should do this.
-
shmel January 26th, 2009 @ 08:17 PM
In my opinion, ability of prawnto to shield user from what is underneath is a great asset. If going forward I will not need to specify "require" for prawn sub-components, I will have fewer things to worry about :)
-
thorny_sun (at cracklabs) February 2nd, 2009 @ 08:17 AM
- Tag set to “prawn0.4, prawnlayout, prawnto”
- State changed from “open” to “resolved”
no huge opinion here, so i've made the change as you've suggested. users will get prawn/layout by default. on github now.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
thorny_sun (at cracklabs)
Gregory Brown